Skip to content

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 26, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

It looks like our fact filter was incorrectly commented out. I added it back in to limit the search results to just docs.

Refs #17990

Is there anything you'd like reviewers to focus on?

Even though this ensures we aren't searching blog posts, it still seems like the results could be refined further to avoid multiple results from the same page. We can handle that in another PR.

@nzakas nzakas requested a review from a team as a code owner June 26, 2024 14:58
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 26, 2024
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 4fa700f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/667c2ca7720eb9000892dfbc
😎 Deploy Preview https://deploy-preview-18627--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas nzakas mentioned this pull request Jun 26, 2024
1 task
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 26, 2024
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Leaving this open for the 2nd review.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've verified that this affects the search results as expected, that is it limits the search to just docs.

https://eslint.org/docs/latest/:

image

This PR's deploy preview:

image

(though, search results still don't look very useful)

@mdjermanovic mdjermanovic merged commit 13dbecd into main Jun 27, 2024
@mdjermanovic mdjermanovic deleted the docs-search-update branch June 27, 2024 07:25
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 25, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants