Skip to content

refactor: Use language.visitorKeys and check for non-JS SourceCode #18625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2024
Merged

refactor: Use language.visitorKeys and check for non-JS SourceCode #18625

merged 1 commit into from
Jun 26, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 25, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Small refactors.

What changes did you make? (Give an overview)

  • Updated so Linter will fall back to language.visitorKeys if sourceCode.visitorKeys is not present.
  • Updated Linter with a better check for an uninitialized SourceCode object.

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner June 25, 2024 17:42
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jun 25, 2024
@github-actions github-actions bot added the core Relates to ESLint's core APIs and features label Jun 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 6e3079c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/667b01738c1a4500086bf48e

mdjermanovic
mdjermanovic approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 7c78ad9 into main Jun 26, 2024
@mdjermanovic mdjermanovic deleted the vkeys-refactor branch June 26, 2024 06:45
@ekmixon ekmixon mentioned this pull request Jul 19, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Jul 19, 2024
Merged
This was referenced Jul 19, 2024
Merged
Open
@jamesleesaunders jamesleesaunders mentioned this pull request Jul 20, 2024
Merged
@lholmquist lholmquist mentioned this pull request Jul 20, 2024
Closed
@saidsef saidsef mentioned this pull request Jul 20, 2024
Closed
@drwho725 drwho725 mentioned this pull request Jul 20, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Jul 20, 2024
Merged
@leoo1992 leoo1992 mentioned this pull request Jul 20, 2024
Merged
@hizumiaoba hizumiaoba mentioned this pull request Jul 20, 2024
Merged
@jadsongmatos jadsongmatos mentioned this pull request Jul 20, 2024
Merged
@junsulee junsulee mentioned this pull request Jul 20, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Jul 24, 2024
Closed
@lholmquist lholmquist mentioned this pull request Jul 24, 2024
Closed
@hashim21223445 hashim21223445 mentioned this pull request Jul 25, 2024
Merged
This was referenced Jul 25, 2024
Closed
Closed
@saidsef saidsef mentioned this pull request Jul 27, 2024
Closed
This was referenced Jul 28, 2024
Open
Open
Open
@lholmquist lholmquist mentioned this pull request Aug 20, 2024
Closed
@justkmode justkmode mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 21, 2024
Closed
Closed
Closed
@jamesleesaunders jamesleesaunders mentioned this pull request Aug 28, 2024
Closed
@lholmquist lholmquist mentioned this pull request Aug 31, 2024
Closed
@ekmixon ekmixon mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 3, 2024
Closed
Closed
@zntb zntb mentioned this pull request Sep 6, 2024
Merged
This was referenced Sep 14, 2024
Closed
Closed
Closed
Closed
@vinitkumar vinitkumar mentioned this pull request Sep 18, 2024
Merged
@lholmquist lholmquist mentioned this pull request Sep 19, 2024
Closed
This was referenced Sep 23, 2024
Open
Open
@lholmquist lholmquist mentioned this pull request Sep 28, 2024
Closed
This was referenced Sep 29, 2024
Merged
Closed
@lholmquist lholmquist mentioned this pull request Oct 1, 2024
Closed
@tygyh tygyh mentioned this pull request Oct 2, 2024
Closed
This was referenced Oct 2, 2024
Closed
Closed
@ebiz-markusrissmann ebiz-markusrissmann mentioned this pull request Oct 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Oct 5, 2024
Closed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 24, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

No one assigned

Labels

archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing core Relates to ESLint's core APIs and features

Projects

Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nzakas @mdjermanovic