docs: Show prerelease version in dropdown #18135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This should be updated, too: |
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
nzakas
added a commit
that referenced
this pull request
Feb 22, 2024
* docs: Show prerelease version in dropdown fixes #17943 * Update docs/src/_data/eslintNextVersion.js Co-authored-by: Milos Djermanovic <[email protected]> * Update docs/src/_includes/components/nav-version-switcher.html Co-authored-by: Milos Djermanovic <[email protected]> * Update versions-list.html --------- Co-authored-by: Milos Djermanovic <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Ensured that the version number is displayed instead of NEXT in the dropdown on the docs site. This is accomplished by either reading the version locally (on the
nextbranch) or fetching the version from GitHub.fixes #17943
Is there anything you'd like reviewers to focus on?
I'm pulling the
package.jsonfrom thenextbranch, but wasn't sure if it should bemain. I don't think it matters much but seemed better to usenextto properly indicate the intent.Note: We'll need to make the same change in the
v8.xbranch.