docs: add more examples to flat config ignores docs #18020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nzakas
reviewed
Jan 22, 2024
docs/src/use/configure/ignore.md
Outdated
| ]; | ||
| ``` | ||
|
|
||
| Patterns that end with `/` can match only directories. Patterns that don't end with `/` can match both files and directories. For example, this config ignores all files in and under `build` directory except for files named `test.js`: |
There was a problem hiding this comment.
This example is really difficult to follow. I don't think this paragraph properly introduces what is happening in the config below. Can you make this more explicit?
There was a problem hiding this comment.
I've now pushed a new version with more details about the example.
Co-authored-by: Nicholas C. Zakas <[email protected]>
|
A text file is much easier to edit than an array. https://github.com/prettier/prettier/blob/b267831086617320f39086c0c704c5a1477fcaa2/eslint.config.js#L257-L261 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #17964
What changes did you make? (Give an overview)
Added a note that ignore pattern like
build/**also ignores directorybuild/. Also added few more examples.Is there anything you'd like reviewers to focus on?