chore: update dependency glob to v10 #17917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
|
Converted to a draft because there are tests failing on Windows. |
fasttime
reviewed
Dec 29, 2023
| const globAsync = promisify(glob); | ||
|
|
||
| // determine which files to check | ||
| const filenames = (await Promise.all(patterns.map(pattern => globAsync(pattern, { nonull: true })))).flat(); |
There was a problem hiding this comment.
nonull is no longer supported.
fasttime
reviewed
Dec 29, 2023
Comment on lines
+58
to
+61
| // Remove OS-dependent path except base name. | ||
| const normalizedStderr = | ||
| // eslint-disable-next-line no-control-regex -- escaping control character | ||
| stderr.replace(/(?<=\x1B\[4m).*(?=bad-examples\.md)/u, ""); |
There was a problem hiding this comment.
On Windows, glob 10 now returns backslash-separated paths.
|
Tests are passing on Windows now. All Makefile tasks seem to work as usual. |
snitin315
approved these changes
Dec 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^7.1.6->^10.0.0globis only used during build in Makefile.js and tools\check-rule-examples.js. The current version 10.3.0 supports all Node.js versions supported by ESLint 9: https://github.com/isaacs/node-glob/blob/v10.3.0/package.json#L96.The main differences from glob v7 are:
posix: true).nonull(https://github.com/isaacs/node-glob/blob/main/changelog.md#options-changes).Release Notes
isaacs/node-glob (glob)
v10.3.10Compare Source
v10.3.9Compare Source
v10.3.8Compare Source
v10.3.7Compare Source
v10.3.6Compare Source
v10.3.5Compare Source
v10.3.4Compare Source
v10.3.3Compare Source
v10.3.2Compare Source
v10.3.1Compare Source
v10.3.0Compare Source
--default -pflag to provide a default patternv10.2.7Compare Source
v10.2.6Compare Source
v10.2.5Compare Source
v10.2.4Compare Source
v10.2.3Compare Source
v10.2.2Compare Source
v10.2.1Compare Source
v10.2.0Compare Source
v10.1.0Compare Source
'.'instead of the empty string''when the currentworking directory is returned as a match.
posix: trueoption to return/delimited paths, even onWindows.
v10.0.0Compare Source
v9.3.5Compare Source
v9.3.4Compare Source
v9.3.3Compare Source
nested extglob patterns.
v9.3.2Compare Source
v9.3.1Compare Source
v9.3.0Compare Source
v9.2.1Compare Source
v9.2.0Compare Source
v9.1.2Compare Source
v9.1.1Compare Source
v9.1.0Compare Source
v9.0.2Compare Source
v9.0.1Compare Source
v9.0.0Compare Source
v8.1.0Compare Source
v8.0.3Compare Source
v8.0.2Compare Source
v8.0.1Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.