Skip to content

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 5, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Removes something from core (formatters)

What changes did you make? (Give an overview)

Removes all but the html, json, json-with-metadata, and stylish formatters.

Is there anything you'd like reviewers to focus on?

This is breaking and will have to wait for the next major version. But I was excited about the work and figured I'd send it in early. 🙂

Fixes #17524.

@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 61532a4
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/656b39ba70f90e0008216528

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 5, 2023 05:17
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner September 5, 2023 05:17
@nzakas nzakas marked this pull request as draft September 5, 2023 15:03
@nzakas
Copy link
Member

nzakas commented Sep 5, 2023

No worries, we'll switch this to a draft. Please be sure to mention the original issue in the PR so it will be closed when this is merged.

@github-actions
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Sep 15, 2023
@Rec0iL99 Rec0iL99 removed the Stale label Sep 15, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat!: remove formatters other than json(-with-metadata) and stylish feat!: remove formatters other than html, json(-with-metadata), and stylish Sep 26, 2023
@eslint-github-bot
Copy link

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@eslint-github-bot
Copy link

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@eslint-github-bot
Copy link

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat!: remove formatters other than html, json(-with-metadata), and stylish feat!: remove formatters except html, json(-with-metadata), and stylish Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Oct 6, 2023
@Rec0iL99 Rec0iL99 removed the Stale label Oct 7, 2023
@github-actions
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Oct 17, 2023
@nzakas nzakas removed the Stale label Oct 18, 2023
@github-actions
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 18, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible feature This change adds a new feature to ESLint formatter Relates to the formatters bundled with ESLint

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Change Request: Remove all formatters except stylish, html, json, and json-with-meta

4 participants