Skip to content

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 8, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

changes package.json license ISC => MIT, Refs 788d836

Is there anything you'd like reviewers to focus on?

n/a.

@aladdin-add aladdin-add requested a review from a team as a code owner June 8, 2023 06:50
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jun 8, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not sure if package.license matters as this isn't a published package. Would like @nzakas to verify.

@mdjermanovic mdjermanovic requested a review from nzakas June 8, 2023 08:23
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Technically it doesn’t matter because we aren’t publishing to npm but it could cause confusion for people just skimming the repo, so good to update this.

@nzakas nzakas merged commit e0a2448 into main Jun 8, 2023
@nzakas nzakas deleted the aladdin-add-patch-1 branch June 8, 2023 16:25
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 6, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants