Skip to content

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Jul 17, 2025

Prerequisites checklist

What is the purpose of this pull request?

Simplify type definitions.

What changes did you make? (Give an overview)

Related Issues

refs eslint/rewrite#177

Related PRs: eslint/eslint#19949, eslint/json#121, eslint/markdown#471

Is there anything you'd like reviewers to focus on?

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leaving it open for others to review.

@snitin315 snitin315 moved this from Needs Triage to Second Review Needed in Triage Jul 18, 2025
@snitin315 snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 18, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir lumirlumir merged commit 3a0886c into main Jul 18, 2025
22 checks passed
@lumirlumir lumirlumir deleted the use-custom-rule-definition-type branch July 18, 2025 05:50
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants