Filter clause for cloudfront service_config #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KingBrewer This looks like it would work, but it doesn't seem to conform with the method used to process other region-agnostic services, like IAM, etc. I'd prefer to see a cloudfront clause in |
|
@nalundgaard I completely agree with you. To be fair I wasn't completely aware of this "method". I was just following the crash stacktrace and found this filter. |
c59f585 to
0d09303
Compare
|
Voila |
|
👍 Thanks for your quick fix @KingBrewer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently CloudFront PR #388 broke
default_configfunction.Fixes: #398
Filter is required, because cloudfront endpoint is agnostic to region (http://docs.aws.amazon.com/general/latest/gr/rande.html#cf_region).