Skip to content

Respect rebar_packages_cdn set in rebar.config #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2022
Merged

Respect rebar_packages_cdn set in rebar.config #2737

merged 1 commit into from
Aug 21, 2022

Conversation

@dmitrivereshchagin
Copy link
Contributor

The value was always overwritten after examining $HEX_CDN.

@dmitrivereshchagin
Respect rebar_packages_cdn set in rebar.config
c8f9861 
The value was always overwritten after examining $HEX_CDN.
ferd
ferd approved these changes Aug 21, 2022
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this works because the reading already uses the default value, so it does not need to be hard-set.

@ferd ferd merged commit 0d95d08 into erlang:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferd ferd ferd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitrivereshchagin @ferd