Template: Revue de presse #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajout d'un template pour le site des revues de presse rdp.epfl.ch
Test Results 1 files 1 suites 0s ⏱️ For more details on these errors, see this check. Results for commit b591035. ♻️ This comment has been updated with latest results. |
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
Solution plus élégante pour l'intégration de classes supplémentaires dans "press-review" (distinguer le "content-type" de l'élément intégré dans une page)
Comment on lines
+72
to
+73
| </div> | ||
| </div> |
Member
There was a problem hiding this comment.
Le nombre de </div> me semble bizarre. J'ai vu la même chose dans d'autres templates.
Je vais essayer de comprendre pourquoi. On peut laisser comme ça en attendant.
| </a> | ||
| </div> | ||
| </div> | ||
| <div class="col-md-8"> |
Member
There was a problem hiding this comment.
Avec une tablette, l'espace n'est pas complétement utilisé. J'avais utilisé col-md-7 col-lg-8 dans rdp.epfl.ch mais tu souhaites peut-être obtenir quelque chose de différent ?
williambelle
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout d'un template pour le site des revues de presse rdp.epfl.ch