New X icon #677
Merged
New X icon #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Twitter logo to X
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
Comment on lines
59
to
60
| .social-icon-twitter { | ||
| background-color: $twitter; |
Member
There was a problem hiding this comment.
Est-ce qu'on peut garder la classe social-icon-twitter pour des raisons de rétrocompatibilité ?
Collaborator
There was a problem hiding this comment.
Je suis d'accord avec @williambelle, il faudrait conserver la classe .social-icon-twitter dans les CSS, sinon les icônes twitter qui ne seraient pas remplacées par l'icône X se retrouveraient sur fond gris clair.
.social-icon-twitter class is back
alinekeller
approved these changes
Aug 22, 2023
williambelle
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Twitter logo to X