Skip to content

Hamburger button #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Hamburger button #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ffc501
Use button tag instead of div
alinekeller Jul 27, 2023
bafcc3d
Use button tag instead of link for nav lang
alinekeller Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/components/atoms/nav-lang/nav-lang.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<nav class="nav-lang ml-auto dropdown" aria-label="Change language">
<a href="#" class="dropdown-toggle btn btn-secondary" aria-haspopup="true" aria-expanded="false" data-toggle="dropdown">
<button class="dropdown-toggle btn btn-secondary" aria-haspopup="true" aria-expanded="false" data-toggle="dropdown">
{% include '@atoms/icon/icon.twig' with {icon: 'icon-planet'} %}
<span>FR</span>
</a>
</button>
<ul class="dropdown-menu">
<li>
<a aria-label="Français (Current language)" class="active dropdown-item" >
Expand Down
4 changes: 2 additions & 2 deletions assets/components/atoms/nav-toggle-mobile/nav-toggle-mobile.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<div class="btn btn-secondary nav-toggle-mobile d-xl-none">
<button class="btn btn-secondary nav-toggle-mobile d-xl-none">
<span class="label">Menu</span>
<div class="hamburger">
<span></span>
<span></span>
<span></span>
</div>
</div>
</button>