Skip to content

feat: add default stats_tags to improve the prometheus metrics #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zirain merged 6 commits into from
Dec 22, 2025
Merged

feat: add default stats_tags to improve the prometheus metrics #7701

zirain merged 6 commits into from
Dec 22, 2025

Conversation

@zirain
Copy link
Member

@zirain zirain commented Dec 9, 2025 •
edited
Loading

xref: #7606

add default stats_tag config to improve the prometheus metric output.

  • add rule for to_zone and from_zone
# TYPE envoy_cluster_zone_upstream_rq_time_count counter
envoy_cluster_zone_1__upstream_rq_time_count{envoy_cluster_name="tracing"} 12 # before
envoy_cluster_zone_upstream_rq_time_count{from_zone="1",envoy_cluster_name="default/tracing-datadog/default/backend"} 0 #after
  • add rule for socket_match_name
# TYPE envoy_cluster_total_match_count counter
envoy_cluster_default_total_match_count{envoy_cluster_name="default/datadog-tracing"} 7 #before
envoy_cluster_total_match_count{socket_match_name="default",envoy_cluster_name="default/datadog-tracing"} 7 #after
  • add rule for circuit breakers priority
# TYPE envoy_cluster_circuit_breakers_default_cx_open gauge
envoy_cluster_circuit_breakers_default_cx_open{envoy_cluster_name="default/datadog-tracing"} 0 #before
envoy_cluster_circuit_breakers_cx_open{priority="default",envoy_cluster_name="default/datadog-tracing"} 0 #after

Before:
before.txt

After:

after.txt

@zirain zirain requested a review from a team as a code owner December 9, 2025 05:40
@codecov
Copy link

codecov bot commented Dec 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.50%. Comparing base (2901f82) to head (8f6df0a).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7701      +/-   ##
==========================================
- Coverage   72.51%   72.50%   -0.01%     
==========================================
  Files         235      235              
  Lines       34857    34859       +2     
==========================================
- Hits        25276    25274       -2     
- Misses       7775     7777       +2     
- Partials     1806     1808       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jukie
jukie previously approved these changes Dec 9, 2025
View reviewed changes
@jukie jukie requested review from a team December 10, 2025 02:13
@arkodg
Copy link
Contributor

arkodg commented Dec 11, 2025

@zirain can you add a diff of before/after to the PR description, so its easier to understand the breaking stat changes

@zirain
Copy link
Member Author

zirain commented Dec 11, 2025 •
edited
Loading

@zirain can you add a diff of before/after to the PR description, so its easier to understand the breaking stat changes

updated

@zirain zirain requested a review from jukie December 13, 2025 08:09
arkodg
arkodg previously approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the release note to highlight the metrics that will break

@zirain zirain requested a review from arkodg December 19, 2025 02:38
arkodg
arkodg previously approved these changes Dec 19, 2025
View reviewed changes
@arkodg arkodg added this to the v1.7.0-rc.1 Release milestone Dec 19, 2025
zhaohuabing
zhaohuabing previously approved these changes Dec 19, 2025
View reviewed changes
@zirain zirain dismissed stale reviews from zhaohuabing and arkodg via 0682dcf December 19, 2025 11:04
@zirain zirain requested review from arkodg and zhaohuabing December 19, 2025 11:04
@zirain
Copy link
Member Author

zirain commented Dec 19, 2025

/retest

cnvergence
cnvergence previously approved these changes Dec 19, 2025
View reviewed changes
jukie
jukie previously approved these changes Dec 20, 2025
View reviewed changes
@zirain
release notes
2c512e3 
Signed-off-by: zirain <[email protected]>
@zirain
fix gen
6d7097c 
Signed-off-by: zirain <[email protected]>
@zirain
update release notes
02a9009 
Signed-off-by: zirain <[email protected]>
@zirain
fix gen
8f6df0a 
Signed-off-by: zirain <[email protected]>
@zirain zirain dismissed stale reviews from jukie and cnvergence via 8f6df0a December 20, 2025 08:17
@zirain zirain requested review from cnvergence and jukie December 21, 2025 01:28
@zirain zirain merged commit 1f1bde1 into envoyproxy:main Dec 22, 2025
54 of 58 checks passed
@zirain zirain deleted the stats-tags branch December 22, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@jukie jukie jukie approved these changes

@arkodg arkodg Awaiting requested review from arkodg

@cnvergence cnvergence Awaiting requested review from cnvergence

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.7.0-rc.1 Release

Development

Successfully merging this pull request may close these issues.

5 participants

@zirain @arkodg @zhaohuabing @jukie @cnvergence