Skip to content

[mob][photos] fix logic of skip flow #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prateekmedia merged 11 commits into from
Dec 22, 2025
Merged

[mob][photos] fix logic of skip flow #8411

prateekmedia merged 11 commits into from
Dec 22, 2025

Conversation

@prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Dec 17, 2025 •
edited
Loading

Description

Contains improvements for skip flow.

  • Only way to reset value of skipped permissions is when first import completes
  • Update manual selection when toggled in on device
  • Always trigger local sync in loading photos widget if !onboarding
  • Also marks first import complete in syncAll flow

Tests

  • tested on emulator

@prateekmedia
never import when skipped, only skip permission in handle backup entr…
56518bf 
…y flow, skip sync remove continue anyway
@prateekmedia
update title + local sync trigger in loading photos widget
1318aab
@prateekmedia
update show loading condition to not show when skipped
d75958d
@prateekmedia
trigger local sync before LoadingPhotosWidget, set manual folder sele…
ed0f928 
…ction on device folder toggle
@prateekmedia
mark first import complete in syncAll when device collections are synced
03e384b
@prateekmedia
add log for local sync trigger in backup flow
1c74f1d
@prateekmedia
only mark first import in syncAll when enableOnlyBackupFuturePhotos f…
777041b 
…lag is on
@prateekmedia
only mark first import in syncAll when flag is on and user had skippe…
8c27494 
…d onboarding permission
@prateekmedia
simplify syncAll first import condition to only check hasSkippedOnboa…
9a1608a 
…rdingPermission
@prateekmedia prateekmedia changed the title [mob][photos] fix skip flow [mob][photos] fix logic of skip flow Dec 18, 2025
@prateekmedia prateekmedia requested a review from ua741 December 19, 2025 12:45
@prateekmedia prateekmedia merged commit aa92e08 into ente-io:main Dec 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ua741 ua741 ua741 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prateekmedia @ua741