-
Couldn't load subscription status.
- Fork 32
docs: add Claude Code CLI setup and API enablement instructions #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add Claude Code CLI configuration section with mcp add-json command - Add required API enablement step for Cloud Resource Manager API - Include CLAUDE.md file with project context for AI assistants Authored-By: jsindy
WalkthroughA new documentation file, CLAUDE.md, was introduced to describe the repository's Model Context Protocol (MCP) server for Google Cloud Platform, including its architecture, tools, and operational guidance. The README.md was updated to add configuration instructions for the Claude Code CLI and clarify GCP API setup steps. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (10)
CLAUDE.md (8)
5-8: Project Overview is concise
Nicely explains the MCP server’s role. Consider linking to the official MCP spec or relevant GCP docs for readers unfamiliar with Model Context Protocol.
9-15: Include CI-friendly install command
It might be helpful to mentionnpm cifor deterministic installs in CI pipelines. For example:- `npm ci` – Install dependencies from lockfile in CI environments
16-24: Improve Architecture formatting
The core components section is detailed but could be easier to scan with consistent indentation. For example:- **Code Execution Engine (`index.ts:24-40`)** - - Sandboxed TypeScript/JavaScript ... + **Code Execution Engine** (`index.ts:24-40`) + - Sandboxed TypeScript/JavaScript execution using `vm`
35-44: Enhance tool list scannability
Consider numbering the nine tools or using individual H3 headings for each to help readers locate a specific tool quickly:1. **run-gcp-code**: ... 2. **list-projects**: ...
46-56: Clarify IAM requirements
Optionally document required IAM roles or scopes for each injected GCP client to prevent permission errors during execution.
58-69: Link to retry/backoff implementation
Link directly to the retry logic inindex.ts:265-277so developers can inspect the exponential backoff code.
70-74: Detail AST transformation
Briefly note which AST nodes are transformed (e.g., expression statements → return statements) when describing code wrapping to set reader expectations.
75-81: Typographical nit: Missing period
Line 81 lacks a terminal period.- All client libraries use the currently selected project by default + All client libraries use the currently selected project by default.🧰 Tools
🪛 LanguageTool
[uncategorized] ~81-~81: A period might be missing here.
Context: ...s use the currently selected project by default(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
README.md (2)
37-42: Document Claude CLI prerequisites
Add a note about installing/updating the Claude CLI before runningclaude mcp add-json:> Ensure you have Claude CLI v1.2.3 or later: > `npm install -g @anthropic/claude-cli`
113-119: Clarify API enablement step
The new step is valuable—consider prefacing that this shifts existing numbering and thatcloudresourcemanager.googleapis.comis required for project listing:2. Enable the Cloud Resource Manager API (needed for `list-projects`): ```bash gcloud services enable cloudresourcemanager.googleapis.com --project=your-project-id</blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between acfc8c173e9a53980231c4a1eccef34fc438c6f4 and 8e72e1f01340c1f1f90c528599da5ad46b8307c7. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `CLAUDE.md` (1 hunks) * `README.md` (2 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 LanguageTool</summary> <details> <summary>CLAUDE.md</summary> [uncategorized] ~81-~81: A period might be missing here. Context: ...s use the currently selected project by default (AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD) </details> </details> </details> <details> <summary>🔇 Additional comments (1)</summary><blockquote> <details> <summary>CLAUDE.md (1)</summary> `1-4`: **Strong title and introduction** The title and opening line clearly establish the document’s purpose for guiding Claude Code integration. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary
claude mcp add-jsoncommandTest plan
Authored-By: jsindy
Summary by CodeRabbit