This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Add Queryset-level delete #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this change make it possible to explicitly delete all rows in the table? Django provides |
Contributor
Author
Sorry, we can't. We need to refactor the QuerySet's method all to implement it. |
dopry
suggested changes
Oct 10, 2019
| await User.objects.delete(name="Jany") | ||
| assert await User.objects.count() == 1 | ||
|
|
||
| await Product.objects.create(name="T-Shirt", rating=5) |
Contributor
There was a problem hiding this comment.
Can we add await Product.objects.create(name="Dress", rating=4) to ensure both filter clauses are respected by build_delete_expression
Contributor
|
This is way too old, and if I'm not mistaken, think #111 is simpler, so I'll close this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
implement Queryset-level delete
I want to reuse build_select_expression, but it seems to no way to change the expression's select column.
The return value of delete method is worth discussing.
Please review