-
-
Notifications
You must be signed in to change notification settings - Fork 979
GitHub Actions: Add Python 3.14 to test matrix #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Ignoring 9 test files passes on Python 3.14rc2. |
3a2447b to
957f9e0
Compare
3e6a024 to
14b880e
Compare
|
Try bumping cryptography from 45.0.7 to latest 46.0.2, which has wheels for 3.14? |
|
OK... Upgraded
|
b2f8b87 to
7be7442
Compare
|
The 3.14 job did collect 1418 items: https://github.com/encode/httpx/actions/runs/18341635177/job/52238338891?pr=3645 But was cancelled because the 3.14t job is failing: https://github.com/encode/httpx/actions/runs/18341635177/job/52238338857?pr=3645 You could add And brotli free-threading support will be coming in a future version: google/brotli#1241 In the meantime, you could leave out 3.14t here. In any case, it would make sense to set |
|
Py3.14t dropped. Py314 hung in pytest... |
|
After reading #3616, perhaps Update: Nope, that did not change the hanging pytests. |
b490e81 to
b533635
Compare
|
The pytest blockage was caused by one of the other dependency upgrades in: |
2ff022f to
1137c1e
Compare
|
|
||
|
|
||
| @pytest.mark.anyio | ||
| @pytest.mark.xfail(sys.version_info >= (3, 14), reason="Fix trio on Python >= 3.14") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this test marked as xfail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it fails. That is what xfail means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it should fail, not being tolerated. Unless there's a valid rationale to mark as xfail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've marked this as "Fix trio on Python >= 3.14"...
- Can you confirm that you've observed this test hanging on
trioand not onasyncio? - Is there a relevant issue for this against trio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Yes. (Is there a way to write the xfail to only pertain to
trio?) --asynciopasses. - I will create one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi 👋 see my try at #3693 |
UPDATE: Python 3.14 (the π version) was released today.
https://www.python.org/downloads/release/python-3140/
https://github.com/actions/python-versions/releases
Summary
Why are 1,418 pytests collected on Python 3.14rc2, but none of them run?
All dependencies are up to date! All other reasonable Python versions pass as expected in about 1 minute.
Read the second comment to see that some tests can pass, but many others go into an infinite loop!
While the tests are not starting, let's temporarily save resources by adding
timeout-minutes: 10.- name: "Run tests" run: "scripts/test" + timeout-minutes: 10 # TODO(@cclauss): Remove once Python 3.14 tests are passing.Checklist
@hugovk Any ideas why pytest fails to execute any tests on Python 3.14rc3?