New Value for QueryParameter: none #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 19, 2021 17:51
instead result in an empty string, if passed to toQueryPair
|
I have an example from my own development: type alias Message =
{ author : String
, title : String
, content : String
, keywords : String
, response_to : Maybe Id
, views : Int
, id : Id
}
query = [ Builder.string "title" message.title
, Builder.string "content" message.content
, Builder.string "keywords" message.keywords
, case message.response_to of
Just r -> Builder.int "response_to" r
Nothing ->
]As you can see, I have a problem, when I get to the Nothing branch. My fixes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many packages expose a none value, such as
Html.noneorCmd.none.Though these values do not do anything, they are useful,
especially if you use
if ... elseorcase ... ofand some casesshould do nothing.
I think it could be useful to introduce such a value to do nothing for the Url.Builder.QueryParameter type
I write some more general functions for requests that cover several cases and
I thus need to use many
case ... ofstatements and it would make this very easy.Currently I am working with list concats and produce code
that is anything but nice on the eyes.
Implementation
With this PR I implement just this feature:
Url.Builder exposes a
none : QueryParametervalue,which results in an empty Query string.