Skip to content

fix([email protected]): Invalid URL #212 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2022
Merged

fix([email protected]): Invalid URL #212 #224

merged 1 commit into from
Aug 6, 2022

Conversation

caoxiemeihao
Copy link
Member

Description

This PR for fix #212

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@caoxiemeihao caoxiemeihao requested a review from youngleish August 6, 2022 02:59
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:

  • package-lock.json
  • yarn.lock
  • pnpm-lock.yaml

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

More discussion:

@caoxiemeihao caoxiemeihao mentioned this pull request Aug 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:

  • package-lock.json
  • yarn.lock
  • pnpm-lock.yaml

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

More discussion:

youngleish
youngleish approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@youngleish youngleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐂

@youngleish youngleish merged commit 05a9c08 into main Aug 6, 2022
@caoxiemeihao caoxiemeihao deleted the fix/220806-#212 branch August 6, 2022 10:01
virgoone pushed a commit to virgoone/electron-vite-vue that referenced this pull request May 19, 2023
@youngleish
Merge pull request electron-vite#224 from electron-vite/fix/220806-#212
b729866 
fix([email protected]): Invalid URL electron-vite#212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youngleish youngleish youngleish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Uncaught TypeError: Failed to construct 'URL': Invalid URL

2 participants

@caoxiemeihao @youngleish