snap: do not set environment for classic #3300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting an environment for classically confined snaps, process that are spawned from within this environment will contaminate the loading of the spawned applications on the system causing symbol mismatches, for this reason it is disabled, making library discovery rely on each binaries RPATH. Signed-off-by: Sergio Schvezov <[email protected]>
|
Test added, verified manuallly: on Xubuntu. But app works and started. |
|
20.28.4 released, thanks! |
shiftkey
pushed a commit
to shiftkey/desktop
that referenced
this pull request
Sep 17, 2018
Add `snap` to `script/electron-builder-linux.yml` and also stage the required packages and set confinement to `classic`. Bump the `electron-builder` version to 20.28.4, this is needed as it fixes a bug when creating Snaps that use classic confinement. * electron-userland/electron-builder#3300
shiftkey
pushed a commit
to shiftkey/desktop
that referenced
this pull request
Sep 18, 2018
Add `snap` to `script/electron-builder-linux.yml` and also stage the required packages and set confinement to `classic`. Bump the `electron-builder` version to 20.28.4, this is needed as it fixes a bug when creating Snaps that use classic confinement. * electron-userland/electron-builder#3300
shiftkey
pushed a commit
to shiftkey/desktop
that referenced
this pull request
Oct 11, 2018
Add `snap` to `script/electron-builder-linux.yml` and also stage the required packages and set confinement to `classic`. Bump the `electron-builder` version to 20.28.4, this is needed as it fixes a bug when creating Snaps that use classic confinement. * electron-userland/electron-builder#3300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting an environment for classically confined snaps,
process that are spawned from within this environment will
contaminate the loading of the spawned applications on the
system causing symbol mismatches, for this reason it is
disabled, making library discovery rely on each binaries
RPATH.
Signed-off-by: Sergio Schvezov [email protected]
--
I am not really much of a javascript developer, running
yarn testproduces this error which seems unrelated:⨯ part download request failed with status code 403