-
Notifications
You must be signed in to change notification settings - Fork 62
docs: adjust installation section #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
theoludwig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it's better that way. 👍
Should we also, include the Docker section, in here? It might make more sense, so that all the installation methods are at the same place?
Should we also link to https://github.com/editorconfig-checker/action-editorconfig-checker and https://github.com/editorconfig-checker/editorconfig-checker.javascript, https://github.com/editorconfig-checker/editorconfig-checker.python, etc?
a8016d6 to
27a39b6
Compare
|
@editorconfig-checker/core can I get another pair of eyes? |
README.md
Outdated
| ### 2. Using Go | ||
|
|
||
| If you have Go installed: | ||
|
|
||
| - Run: | ||
|
|
||
| `go get github.com/editorconfig-checker/editorconfig-checker/v3` <!-- x-release-please-major --> | ||
|
|
||
| - Then build the binary: | ||
| ```shell | ||
| make build | ||
| ``` | ||
| - The binary will be placed in the `bin` directory as `ec`. | ||
|
|
||
| Alternatively, with Go 1.16+ you can install globally: | ||
|
|
||
| ```shell | ||
| mise use -g editorconfig-checker@latest | ||
| go install github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker@latest | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would invert and make go install first. Go 1.16 is really old now
3ebf183 to
174df6c
Compare
I've added nix and brew installation methods.
The list is ordered by: