Add support to inject other pip index #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, python dependencies were only downloaded from the index defined in requirements.txt. This is a limitation of rules_py, which usually uses the bazel downloader for python dependencies. However, if a locked requirements.txt is provided, it directly uses pip to download patches from the index specified in the file. Allow specifying custom index URLs through an environment variable.
|
@AlexanderLanin could you please review this pull request? |
There was a problem hiding this comment.
Pull Request Overview
This PR enables specifying a custom pip index URL via an environment variable when using pip to download dependencies in Bazel.
- Enhances pip.parse() in MODULE.bazel with envsubst and extra_pip_args parameters.
- Removes a trailing '-' line at the end of the file, potentially cleaning up file formatting.
Comments suppressed due to low confidence (1)
python_basics/MODULE.bazel:61
- [nitpick] The removal of the trailing '-' line may be unintentional or affect file formatting consistency. Please verify if this change was intended.
use_repo(multitool, "multitool")
AlexanderLanin
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, python dependencies were only downloaded from the index
defined in requirements.txt. This is a limitation of rules_py, which usually uses
the bazel downloader for python dependencies. However, if a locked
requirements.txt is provided, it directly uses pip to download patches
from the index specified in the file.
Allow specifying custom index URLs through an environment variable.
Similar to eclipse-score/docs-as-code#103.