Skip to content

Conversation

@prabakaranklst
Copy link
Contributor

Updated files to fix review comments, CI failure and appearance.

@github-actions
Copy link

⚠️ Docs-as-Code version mismatch detected
Please check the CI build logs for details and align the documentation version with the Bazel dependency.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@prabakaranklst prabakaranklst force-pushed the prabakaran_orchestration_feature_arch_update branch from 21ddb8e to 04bbe00 Compare October 23, 2025 12:17
@prabakaranklst prabakaranklst force-pushed the prabakaran_orchestration_feature_arch_update branch from 04bbe00 to 28977b9 Compare October 23, 2025 13:57
Copy link
Contributor

@PandaeDo PandaeDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for the moment

Copy link
Contributor

@PandaeDo PandaeDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the names as described in the names conventions so that they are listed in e.g. the documentation plan

@prabakaranklst prabakaranklst force-pushed the prabakaran_orchestration_feature_arch_update branch from 28977b9 to 1194854 Compare October 24, 2025 08:46
@vinodreddy-g vinodreddy-g force-pushed the prabakaran_orchestration_feature_arch_update branch from b78f9c0 to b7d91f7 Compare October 24, 2025 11:45
:included_by: logic_arc_int__orchestration__design


.. logic_arc_int_op:: bind_events_as_global
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please align API with current state for deployment design and OrchProgManager

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

Component Architecture
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are missing dependecy to mw_com or ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no ID defined with mw_com and related text in communication feature. So, it cannot be added.

@pawelrutkaq
Copy link
Contributor

@PandaeDo @vinodreddy-g all req should be tagged asilb or ?

@vinodreddy-g
Copy link
Contributor

@PandaeDo @vinodreddy-g all req should be tagged asilb or ?

Yes for all the functional req for orchestration.

vinodreddy-g and others added 4 commits October 28, 2025 15:10
Updated files to fix review comments, CI failure and appearance.
Updated files to fix review comments, CI failure and appearance.
@prabakaranklst prabakaranklst force-pushed the prabakaran_orchestration_feature_arch_update branch from b7d91f7 to 2bdcabb Compare October 28, 2025 14:05
@prabakaranklst
Copy link
Contributor Author

Rebased and fixed review comments.

add depndency on mw::com frontend
@pawelrutkaq
Copy link
Contributor

The safety levels and meanings will be adjusted in follow up PRs

Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as of now

fix modules to components in orchestrator .Two components executor and orchestrator.
@vinodreddy-g vinodreddy-g merged commit 7d5a7e2 into eclipse-score:main Oct 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants