-
Couldn't load subscription status.
- Fork 64
FuSa evaluation draft of gtest #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FuSa evaluation draft of gtest #1907
Conversation
Added drawio diagram Updated evaluation
|
|
|
The created documentation from the pull request is available at: docu-html |
- added comment in requirements section - updated diagram - removed compiler examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix GTest also on a diagram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed name
|
@PiotrKorkus, fixed the changes. Could you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
docs/score_tools/gtest.rst
Outdated
|
|
||
| Available information | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
| - S-CORE baselibs: https://github.com/eclipse-score/baselibs/blob/main/MODULE.bazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs better documentation what it is: e.g. "example configuration of Gtest version for use in a S-CORE module repository"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e098b4d8d
docs/score_tools/gtest.rst
Outdated
| ---------------------------- | ||
| Installation | ||
| ~~~~~~~~~~~~ | ||
| | Provided as part of baselibs (https://github.com/eclipse-score/baselibs/blob/main/MODULE.bazel). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not so sure if we should state this as such e.g. see https://github.com/eclipse-score/communication/blob/main/MODULE.bazel - maybe write if you use baselibs it is already a dependency there, but if not then ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed reference to baselibs: e098b4d8d
| ---------- | ||
| This section evaluates GTest for use in S-CORE project. | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend to have a Heading here "Safety evaluation"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| - yes | ||
| - no | ||
| - high | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend to have a Heading here "Security evaluation"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated table heading as suggested
docs/score_tools/gtest.rst
Outdated
| :header-rows: 1 | ||
| :widths: 1 2 8 2 6 4 2 2 | ||
|
|
||
| * - Use case Identification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the Id should be a "Malfunction" Id or a "Use Case / Malfunction" Id 1-1, 1-2, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to " Malfunction identification"
|
|
||
| GTest fails to detect the presence of existing errors. | ||
| - yes | ||
| - / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unclear what it means, better write "no"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed "Verify the test plan and test report", added "no"
|
|
||
| GTest indicates the presence of errors that do not exist. | ||
| - no | ||
| - / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unclear what it means, better write "no"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed "Verify the test plan and test report", added "no"
docs/score_tools/gtest.rst
Outdated
| GTest requires qualification for use in safety-related software development according to ISO 26262. | ||
|
|
||
|
|
||
| **Optional Section for Tool Qualification** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the "Optional Section for" as we need this for GTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
docs/score_tools/gtest.rst
Outdated
|
|
||
| Requirements and testing aspects | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Tool requirements are derived from official documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more specific here? Is there a folder for this in the used version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly referring to user guide: https://google.github.io/googletest/ .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added link to documentation.
|
|
||
| Available information | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
| - Version: 1.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is gtest version 1.15.0 here set as an example?
I have troubles with it when trying to migrate baselibs to bazel 8.3.1.
The 1.15.0 is incompatible with bazel 8.x: https://registry.bazel.build/modules/googletest/1.15.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to check that.
Currently there are 4 different gtest versions used in projects (1.14, 1.15, 1.17 and 1.17.0.bcr.1)
Added safety evaluation draft of gtest