Skip to content

Conversation

@alekseyborisyukvalidas
Copy link
Contributor

Added safety evaluation draft of gtest

@alekseyborisyukvalidas alekseyborisyukvalidas requested a review from a team as a code owner October 15, 2025 14:47
@github-actions
Copy link

⚠️ Docs-as-Code version mismatch detected
Please check the CI build logs for details and align the documentation version with the Bazel dependency.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

- added comment in requirements section
- updated diagram
- removed compiler examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix GTest also on a diagram

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed name

@alekseyborisyukvalidas
Copy link
Contributor Author

@PiotrKorkus, fixed the changes. Could you please have a look?

Copy link
Contributor

@PiotrKorkus PiotrKorkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it lgtm

Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments


Available information
~~~~~~~~~~~~~~~~~~~~~
- S-CORE baselibs: https://github.com/eclipse-score/baselibs/blob/main/MODULE.bazel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs better documentation what it is: e.g. "example configuration of Gtest version for use in a S-CORE module repository"

Copy link
Contributor Author

@alekseyborisyukvalidas alekseyborisyukvalidas Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e098b4d8d

----------------------------
Installation
~~~~~~~~~~~~
| Provided as part of baselibs (https://github.com/eclipse-score/baselibs/blob/main/MODULE.bazel).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so sure if we should state this as such e.g. see https://github.com/eclipse-score/communication/blob/main/MODULE.bazel - maybe write if you use baselibs it is already a dependency there, but if not then ...

Copy link
Contributor Author

@alekseyborisyukvalidas alekseyborisyukvalidas Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed reference to baselibs: e098b4d8d

----------
This section evaluates GTest for use in S-CORE project.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend to have a Heading here "Safety evaluation"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

- yes
- no
- high

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend to have a Heading here "Security evaluation"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated table heading as suggested

:header-rows: 1
:widths: 1 2 8 2 6 4 2 2

* - Use case Identification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the Id should be a "Malfunction" Id or a "Use Case / Malfunction" Id 1-1, 1-2, ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to " Malfunction identification"


GTest fails to detect the presence of existing errors.
- yes
- /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear what it means, better write "no"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed "Verify the test plan and test report", added "no"


GTest indicates the presence of errors that do not exist.
- no
- /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear what it means, better write "no"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed "Verify the test plan and test report", added "no"

GTest requires qualification for use in safety-related software development according to ISO 26262.


**Optional Section for Tool Qualification**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the "Optional Section for" as we need this for GTest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


Requirements and testing aspects
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tool requirements are derived from official documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be more specific here? Is there a folder for this in the used version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly referring to user guide: https://google.github.io/googletest/ .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link to documentation.


Available information
~~~~~~~~~~~~~~~~~~~~~
- Version: 1.15.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gtest version 1.15.0 here set as an example?
I have troubles with it when trying to migrate baselibs to bazel 8.3.1.
The 1.15.0 is incompatible with bazel 8.x: https://registry.bazel.build/modules/googletest/1.15.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to check that.
Currently there are 4 different gtest versions used in projects (1.14, 1.15, 1.17 and 1.17.0.bcr.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants