Skip to content

Feature Request: JSON Parser #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 11, 2025
Merged

Feature Request: JSON Parser #822

merged 24 commits into from
Aug 11, 2025

Conversation

@alexandruiulian10
Copy link
Contributor

@alexandruiulian10 alexandruiulian10 commented Mar 31, 2025 •
edited by AlexanderLanin
Loading

Provides a proposal for a safe JSON parser feature.

@github-actions
Copy link

github-actions bot commented Mar 31, 2025 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 62a09ee5-9071-436d-8e1f-6338083f0669
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/score/score/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/score/score/BUILD
INFO: Elapsed time: 4.964s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

simon-acc
simon-acc reviewed Mar 31, 2025
View reviewed changes
@alexandruiulian10 alexandruiulian10 force-pushed the json_feature_request branch 2 times, most recently from 2fb2df2 to 29b929c Compare April 1, 2025 12:37
rattenking52
rattenking52 suggested changes Apr 1, 2025
View reviewed changes
masc2023
masc2023 reviewed Apr 14, 2025
View reviewed changes
@ramceb ramceb moved this to In Progress in Feature Requests / Modification Apr 14, 2025
rattenking52
rattenking52 suggested changes May 5, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 7, 2025

The created documentation from the pull request is available at: docu-html

@alexandruiulian10 alexandruiulian10 force-pushed the json_feature_request branch 4 times, most recently from 5c9e3a9 to 70d0134 Compare May 9, 2025 13:58
alexandruiulian10 and others added 7 commits May 9, 2025 17:05
@alexandruiulian10
json-lib: JSON Feature Proposal
fd2cadf 
Signed-off-by: Alexandru Iulian <[email protected]>
@alexandruiulian10
json-lib: Fix typo in /docs/features/communication/json/index.rst
adf23df 
Signed-off-by: Alexandru Iulian <[email protected]>
@alexandruiulian10 @rattenking52
json-lib: Rephrase JSON parser requirements to be more generic.
008bb9b 
Co-authored-by: rattenking52 <[email protected]>
Signed-off-by: Alexandru Iulian <[email protected]>
@alexandruiulian10
json-lib: Move JSON Parser feature request to baselibs folder
ebf2209 
Signed-off-by: Alexandru Iulian <[email protected]>
@alexandruiulian10 @rattenking52
json-lib: Rephrase some descriptions to be consistent with requirements
fd85fb6 
Co-authored-by: rattenking52 <[email protected]>
Signed-off-by: Alexandru Iulian <[email protected]>
@alexandruiulian10
json-lib: Remove unneeded linkage in JSON parser requrements
6295864 
Signed-off-by: Alexandru Iulian <[email protected]>
@alexandruiulian10 @rattenking52
json-lib: Rename JSON Parser to JSON-Library
0684f44 
Co-authored-by: rattenking52 <[email protected]>
Signed-off-by: Alexandru Iulian <[email protected]>
lammjo
lammjo reviewed May 15, 2025
View reviewed changes
alexandruiulian10
alexandruiulian10 commented May 15, 2025
View reviewed changes
masc2023
masc2023 reviewed May 15, 2025
View reviewed changes
arsibo
arsibo reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@arsibo arsibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements are fine from logging side
https://github.com/orgs/eclipse-score/discussions/1414#discussioncomment-13787441

@4og 4og self-requested a review July 29, 2025 15:37
4og
4og previously requested changes Jul 29, 2025
View reviewed changes
aschemmel-tech
aschemmel-tech requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments originally from masc2023 still have to be resolved

LittleHuba
LittleHuba reviewed Jul 31, 2025
View reviewed changes
aschemmel-tech
aschemmel-tech requested changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also updated inline comments

PhilipPartsch
PhilipPartsch reviewed Jul 31, 2025
View reviewed changes
aschemmel-tech
aschemmel-tech approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment that needed fixing resolved, so I approve

@aschemmel-tech aschemmel-tech dismissed 4og’s stale review August 8, 2025 09:54

The findings were resolved by later commits

@aschemmel-tech aschemmel-tech merged commit 23cebcb into eclipse-score:main Aug 11, 2025
6 checks passed
@alexandruiulian10 alexandruiulian10 deleted the json_feature_request branch September 9, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilipPartsch PhilipPartsch PhilipPartsch left review comments

@simon-acc simon-acc simon-acc left review comments

@LittleHuba LittleHuba LittleHuba left review comments

@arsibo arsibo arsibo left review comments

@masc2023 masc2023 masc2023 left review comments

@aschemmel-tech aschemmel-tech aschemmel-tech approved these changes

@antonkri antonkri antonkri approved these changes

@4og 4og 4og left review comments

@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner

@qor-lb qor-lb Awaiting requested review from qor-lb qor-lb is a code owner

@johannes-esr johannes-esr Awaiting requested review from johannes-esr johannes-esr is a code owner

@markert-r markert-r Awaiting requested review from markert-r

+6 more reviewers

@lammjo lammjo lammjo left review comments

@mishu-dev mishu-dev mishu-dev left review comments

@lennartbecker-d lennartbecker-d lennartbecker-d left review comments

@sankurm sankurm sankurm left review comments

@rattenking52 rattenking52 rattenking52 approved these changes

@hoppe-and-dreams hoppe-and-dreams hoppe-and-dreams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community:architecture feature_request

Projects

Feature Requests / Modification
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request for qualified json-parser