Fix supervisor API [ECR-4368] #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because it makes generated JSON incompatible with JSON presentation of the Protobuf message.
aleksuss
approved these changes
Mar 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
- Coverage 94.82% 94.79% -0.03%
==========================================
Files 269 269
Lines 42373 42521 +148
==========================================
+ Hits 40180 40309 +129
- Misses 2193 2212 +19
Continue to review full report at Codecov.
|
alekseysidorov
approved these changes
Mar 24, 2020
...from `application/octet-stream` payloads
This is beneficial for documentation clarity and testing.
977b7e8 to
8d504d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes issues brought into supervisor API in #1823:
bytes/Vec<u8>fields are serialized in hex rather than base64 as prescribed by Protobuftag = "type"for theConfigChangeenum makes it incompatible with canonical JSON formatI have an idea to make a generic solution for
ServiceApiScope, which would enable endpoints to accept either JSON or Protobuf, depending on the passedContent-Type. This may take some time though.See: https://jira.bf.local/browse/ECR-4368