Skip to content

Some refactoring by clippy suggestion #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2019
Merged

Some refactoring by clippy suggestion #1357

merged 1 commit into from
Jun 24, 2019

Conversation

@aleksuss
Copy link
Contributor

@aleksuss aleksuss commented Jun 18, 2019

Definition of Done

  • There are no TODOs left in the merged code
  • Change is covered by automated tests
  • Benchmark results are attached (if applicable)
  • The coding guidelines are followed
  • Public API has proper documentation
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1357 into dynamic_services will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           dynamic_services    #1357      +/-   ##
====================================================
+ Coverage             95.83%   95.85%   +0.01%     
====================================================
  Files                    32       32              
  Lines                  5809     5809              
====================================================
+ Hits                   5567     5568       +1     
+ Misses                  242      241       -1
Impacted Files Coverage Δ
components/merkledb/src/sparse_list_index.rs 96.55% <ø> (ø) ⬆️
components/merkledb/src/keys.rs 99.1% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5536d8...4da76d5. Read the comment docs.

@aleksuss aleksuss merged commit 90499eb into exonum:dynamic_services Jun 24, 2019
@aleksuss aleksuss deleted the ds_some_refactoring branch July 3, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alekseysidorov alekseysidorov Awaiting requested review from alekseysidorov

@popzxc popzxc Awaiting requested review from popzxc

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aleksuss