Remove unsafe code from runtimes #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2019 11:19
aleksuss
approved these changes
May 30, 2019
popzxc
approved these changes
May 30, 2019
Contributor
popzxc
left a comment
There was a problem hiding this comment.
About impl RuntimeEnvironment for Dispatcher: I don't think that it's bad if we won't do this.
Dispatcher is a singleton entity which won't be used in any polymorphic context. It doesn't have to implement this trait to get more functionality, it was implemented only for logical consistence.
If there are some restrictions that aren't allow us to make Dispatcher a RuntimeEnvironment, it's ok. Nothing will broke and design won't become worse.
popzxc
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.