Skip to content

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Feb 23, 2024

Description

Remove Chain ID constraint to 9000 / 9001

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@facs95 facs95 requested a review from a team as a code owner February 23, 2024 00:41
@facs95 facs95 requested review from GAtom22 and Vvaradinov and removed request for a team February 23, 2024 00:41
@github-actions github-actions bot added the tests label Feb 23, 2024
@luchenqun
Copy link
Contributor

Well done!Why was this restriction added in the first place?

@fedekunze
Copy link
Collaborator

Why was this restriction added in the first place?

we didn't have the non-commercial license then. This is now enforced this license and we've built a legal team that can enforce its compliance

@fedekunze fedekunze enabled auto-merge (squash) February 23, 2024 07:24
@fedekunze fedekunze merged commit affc6b6 into main Feb 23, 2024
@fedekunze fedekunze deleted the facs95/chain-id branch February 23, 2024 10:03
MalteHerrmann pushed a commit that referenced this pull request Apr 23, 2024
@0xstepit
Copy link
Contributor

@Mergifyio backport release/v18.0.x

Copy link
Contributor

mergify bot commented May 27, 2024

backport release/v18.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 27, 2024
facs95 added a commit that referenced this pull request May 29, 2024
GAtom22 added a commit that referenced this pull request May 29, 2024
* imp(evm): Remove ChainID constraint (#2373)

* update chlog

---------

Co-authored-by: tom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants