Skip to content

chore(server): adjust default app configuration to disable all server options #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023
Merged

chore(server): adjust default app configuration to disable all server options #1623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions server/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ type TLSConfig struct {
func AppConfig(denom string) (string, interface{}) {
// Optionally allow the chain developer to overwrite the SDK's default
// server config.
srvCfg := config.DefaultConfig()
customAppConfig := DefaultConfig()

// The SDK's default minimum gas price is set to "" (empty value) inside
// app.toml. If left empty by validators, the node will halt on startup.
Expand All @@ -164,14 +164,7 @@ func AppConfig(denom string) (string, interface{}) {
//
// In evmos, we set the min gas prices to 0.
if denom != "" {
srvCfg.MinGasPrices = "0" + denom
}

customAppConfig := Config{
Config: *srvCfg,
EVM: *DefaultEVMConfig(),
JSONRPC: *DefaultJSONRPCConfig(),
TLS: *DefaultTLSConfig(),
customAppConfig.Config.MinGasPrices = "0" + denom
}

customAppTemplate := config.DefaultConfigTemplate + DefaultConfigTemplate
Expand All @@ -181,8 +174,15 @@ func AppConfig(denom string) (string, interface{}) {

// DefaultConfig returns server's default configuration.
func DefaultConfig() *Config {
defaultSDKConfig := config.DefaultConfig()
defaultSDKConfig.API.Enable = false
defaultSDKConfig.GRPC.Enable = false
defaultSDKConfig.GRPCWeb.Enable = false
defaultSDKConfig.Rosetta.Enable = false
defaultSDKConfig.Telemetry.Enabled = false

return &Config{
Config: *config.DefaultConfig(),
Config: *defaultSDKConfig,
EVM: *DefaultEVMConfig(),
JSONRPC: *DefaultJSONRPCConfig(),
TLS: *DefaultTLSConfig(),
Expand Down Expand Up @@ -219,7 +219,7 @@ func GetAPINamespaces() []string {
// DefaultJSONRPCConfig returns an EVM config with the JSON-RPC API enabled by default
func DefaultJSONRPCConfig() *JSONRPCConfig {
return &JSONRPCConfig{
Enable: true,
Enable: false,
API: GetDefaultAPINamespaces(),
Address: DefaultJSONRPCAddress,
WsAddress: DefaultJSONRPCWsAddress,
Expand Down