feat(fees): enable fees to be deducted from unclaimed staking rewards #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 15, 2023 12:42
…ents to readability
added 2 commits
February 17, 2023 11:28
fedekunze
reviewed
Feb 17, 2023
fedekunze
reviewed
Feb 24, 2023
added 6 commits
February 24, 2023 20:31
fedekunze
approved these changes
Feb 28, 2023
* chore(tests) add insufficient fees unit test * chore(tests) add min gas price == 0 unit test * chore(tests) add fee granter tests * fix lint issues * fix cosmos tests * add fees unit test case * add zero fees unit test case * add unit test without freegrant keeper
Vvaradinov
approved these changes
Feb 28, 2023
GAtom22
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the mechanics to achieve milestone 1 of the "fee subscription" initiative, which enables transaction fees to be deducted from unclaimed staking rewards.
Closes ENG-1199