Skip to content

deps: bump sdk (v0.46.11) & use cometbft v0.34.27 replacement #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 24, 2023
Merged

deps: bump sdk (v0.46.11) & use cometbft v0.34.27 replacement #1492

merged 6 commits into from
Mar 24, 2023

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Mar 23, 2023 •
edited
Loading

Description

Bump dependencies:

  • Cosmos SDK to v0.46.11
  • Replace informal systems fork by cometbft v0.34.27 on Tendermint replace

Closes https://linear.app/evmos/issue/ENG-1568/migrate-tendermint-to-comet-bft

@linear
Copy link

linear bot commented Mar 23, 2023

ENG-1568 Migrate Tendermint to Comet BFT

Upgrade tendermint to CometBFT v0.34.27

Open Questions

  • What are the expected improvements from this migration?
  • Is this blocked by upgrading the SDK to v0.47?

Scope of Work

  • Update our Cosmos SDK fork with the changes on v0.46.11 of the Cosmos SDK
  • Make a new release of our Cosmos SDK fork: v0.46.11-ledger
  • Update Evmos with the new Cosmos SDK fork version
  • Make the corresponding replacement on Evmos (guide here)

@GAtom22 GAtom22 changed the title deps: bump sdk & cometbft version deps: bump sdk (v0.46.11) & use cometbft v0.34.27 replacement Mar 23, 2023
@GAtom22 GAtom22 marked this pull request as ready for review March 23, 2023 20:06
@GAtom22 GAtom22 requested a review from a team as a code owner March 23, 2023 20:06
@GAtom22 GAtom22 requested review from MalteHerrmann, Vvaradinov, austinchandra and facs95 and removed request for a team March 23, 2023 20:06
MalteHerrmann
MalteHerrmann approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MalteHerrmann MalteHerrmann merged commit 69d00b8 into main Mar 24, 2023
@MalteHerrmann MalteHerrmann deleted the GAtom22/bump-sdk-dep branch March 24, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facs95 facs95 Awaiting requested review from facs95 facs95 is a code owner automatically assigned from evmos/core-engineering

@austinchandra austinchandra Awaiting requested review from austinchandra

2 more reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@MalteHerrmann MalteHerrmann MalteHerrmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GAtom22 @Vvaradinov @MalteHerrmann