Skip to content

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Feb 10, 2023

Description

After the Ethermint migration we eneded up organzing the decorator between evm specific decorators under the evm package and cosmos decorator under their cosmos package.

This PR makes the corresponding separation for the vesting decorators


Closes https://linear.app/evmos/issue/ENG-1501/split-vesting-decorators-between-evm-and-cosmos-packages

@linear
Copy link

linear bot commented Feb 10, 2023

ENG-1501 split Vesting decorators between EVM and Cosmos packages

After the Ethermint migration we eneded up organzing the decorator between evm specific decorators under the evm package and cosmos decorator under their cosmos cosmos package.

Right now the vesting decorator are not following that order

@GAtom22 GAtom22 marked this pull request as ready for review February 10, 2023 13:14
@GAtom22 GAtom22 requested review from a team and ramacarlucho as code owners February 10, 2023 13:14
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1380 (05c33b1) into main (2cadb51) will increase coverage by 0.06%.
The diff coverage is 32.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
+ Coverage   72.08%   72.15%   +0.06%     
==========================================
  Files         257      258       +1     
  Lines       17560    17560              
==========================================
+ Hits        12658    12670      +12     
+ Misses       4338     4324      -14     
- Partials      564      566       +2     
Impacted Files Coverage Δ
app/ante/cosmos/vesting.go 0.00% <ø> (ø)
app/ante/handler_options.go 33.33% <0.00%> (ø)
app/ante/evm/vesting.go 35.29% <35.29%> (ø)

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending changelog

@fedekunze fedekunze merged commit fb15df3 into main Feb 10, 2023
@fedekunze fedekunze deleted the GAtom22/vesting-decorators branch February 10, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants