chore(imp) refactor to use BaseDenom #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1495 Change code where ClaimsDenom & EvmDenom is used for BaseDenom
To avoid confusion and decrease the complexity of code & tests, refactor code where there is the (now inexistent) distinction between claims denomination and EVM denomination. Replace this to use BaseDenom |
fedekunze
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Perform refactor to use
BaseDenominstead of usingClaimsDenomandEvmDenomCloses https://linear.app/evmos/issue/ENG-1495/change-code-where-claimsdenom-and-evmdenom-is-used-for-basedenom