imp: restrict chain ID to Evmos #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1485 Restrict chain IDs on Evmos
Prevent the use of the EVM from other ID other than Evmos' ( Scope of Work
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
- Coverage 71.59% 71.55% -0.05%
==========================================
Files 256 256
Lines 17509 17544 +35
==========================================
+ Hits 12536 12554 +18
- Misses 4417 4431 +14
- Partials 556 559 +3
|
…& rename some imports" This reverts commit 116902f.
facs95
approved these changes
Feb 8, 2023
mtsitrin
added a commit
to dymensionxyz/evmos
that referenced
this pull request
Jun 21, 2023
This reverts commit 7a6d9b7.
|
Can someone explain this breaking change? |
|
Maybe @facs95 knows the reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restricts the Evmos codebase from working with chain IDs other than 9000 and 9001
Closes https://linear.app/evmos/issue/ENG-1485/restrict-chain-ids-on-evmos