[fix] Error on non-numeric patch version #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some build systems (such as `nix-unstable`) there is a 4th non-numeric patch version such as `47.3.1.post20201006` that causes this version extraction to fail. Since the code only requires the numeric part the extraction is limited to the `major.minor` part of `major.minor.patch.patch-date`.
10 tasks
Owner
|
@fabianhjr Thanks for the fix! This should be live on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some build systems (such as
nix-unstable) there is a 4th non-numeric patchversion such as
47.3.1.post20201006that causes this version extraction tofail. Since the code only requires the numeric part the extraction is limited to
the
major.minorpart ofmajor.minor.patch.patch-date.