Auth spec shouldn't specify which methods are provided over it #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
There was a discussion around this statement in the original auth PR #167 (comment). It was suggested to remove this statement with no opposition to the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly confused by this statement in the authentication spec. It appears the current state of the authentication spec (all legacy method should be provided) is contradicting the PR #183 (only a subset should be provided). Unless I misinterpret and the "legacy api" is the non-authenticated engine api? In which case believe the idea was to still remove that?