Skip to content

fix: language picker fallback logic #16458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: language picker fallback logic #16458

wants to merge 1 commit into from
+15 −4

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 7, 2025

Description

When a language name is the same in both English and that language, logic treats this as if the translated form is not available for that locale, and falls back to the Intl.DisplayName JavaScript library. In certain cases this is undesired, such as with Tagalog, whose name is the same in English and Taglog, falls back to the JS library and results in "Filipino" (but we already have Filipino specifically.

  • Adds a boolean forceLocalName to the I18nLocale type (adding intellisense documentation for future clarity) to to override this and use the locale name instead
  • Adds "language-tl": "Tagalog", to both en/common.json and tl/common.json files

Related Issue

image

@netlify Netlify
Copy link

netlify bot commented Oct 7, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68e5a8f9a59cf2f355ac6f77
😎 Deploy Preview https://deploy-preview-16458--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Oct 7, 2025
@wackerow
Copy link
Member Author

wackerow commented Oct 8, 2025

Initial build timed out:

12:00:42 PM: Failed during stage 'building site': Command did not finish within the time limit
12:00:42 PM: Execution timed out after 1h30m0.454590714s

Re-triggered from Netlify -> build completed successfully:
https://app.netlify.com/projects/ethereumorg/deploys/68e5a8f9a59cf2f355ac6f77

(Lighthouse task timed out on /en/)

6:28:23 PM: Generating Lighthouse reports. This may take a minute…
6:28:23 PM: Running Lighthouse on /en/ (1/7)
6:28:30 PM: Execution timed out after 1h30m0.521147112s

Preview link live:
https://deploy-preview-16458--ethereumorg.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wackerow