Skip to content

fix: language picker fallback logic #16458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: language picker fallback logic #16458

wants to merge 1 commit into from
+15 −4

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 7, 2025

Description

When a language name is the same in both English and that language, logic treats this as if the translated form is not available for that locale, and falls back to the Intl.DisplayName JavaScript library. In certain cases this is undesired, such as with Tagalog, whose name is the same in English and Taglog, falls back to the JS library and results in "Filipino" (but we already have Filipino specifically.

  • Adds a boolean forceLocalName to the I18nLocale type (adding intellisense documentation for future clarity) to to override this and use the locale name instead
  • Adds "language-tl": "Tagalog", to both en/common.json and tl/common.json files

Related Issue

image

@wackerow wackerow requested review from corwintines, minimalsm and pettinarip as