Use golang.org/x/sys/windows for FileLockEx/UnlockFileEx
#283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the FileLockEx and UnlockFileEx wrappers and the corresponding LOCKFILE_* and the ERROR_LOCK_VIOLATION error constants from the golang.org/x/sys/windows package rather than implementing these in the package.
5257b02 to
805eb40
Compare
|
@ptabor care to take a look at this? This is doing the same that etcd-io/etcd#13146 did for etcd. Thank you! |
ptabor
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
FileLockExandUnlockFileExwrappers and the correspondingLOCKFILE_*and theERROR_LOCK_VIOLATIONerror constant from thegolang.org/x/sys/windowspackage rather than implementing these in thepackage.