Skip to content

build(deps): Bump golang.org/x/sync from 0.15.0 to 0.16.0 #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2025
Merged

build(deps): Bump golang.org/x/sync from 0.15.0 to 0.16.0 #1028

merged 1 commit into from
Jul 20, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 14, 2025 •
edited
Loading

Bumps golang.org/x/sync from 0.15.0 to 0.16.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 14, 2025
@k8s-ci-robot
Copy link

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/sync-0.16.0 branch from e16ebf1 to 01f547a Compare July 15, 2025 19:27
@ahrtr
Copy link
Member

ahrtr commented Jul 15, 2025

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented Jul 17, 2025

/retest

@ahrtr
Copy link
Member

ahrtr commented Jul 17, 2025

It seems that we have to increase the execution time for windows.

@ivanvc
Copy link
Member

ivanvc commented Jul 18, 2025

Related to: #1030 (comment)

@ivanvc
Copy link
Member

ivanvc commented Jul 18, 2025

@ahrtr, with #1031 merged, can you run "@dependabot rebase" on this PR? Thanks

@ahrtr
Copy link
Member

ahrtr commented Jul 18, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/sync-0.16.0 branch from 01f547a to 625f8a5 Compare July 18, 2025 20:44
@ahrtr
Copy link
Member

ahrtr commented Jul 19, 2025

@Elbehery it seems 40m isn't still enough. Let's try 50m?

@Elbehery
Copy link
Member

@Elbehery it seems 40m isn't still enough. Let's try 50m?

yes, that's what I thought and commented in #1030 (comment)

bumping to 50m now 👍🏽 ...

@Elbehery Elbehery mentioned this pull request Jul 19, 2025
Merged
@ahrtr
Copy link
Member

ahrtr commented Jul 19, 2025

@dependabot rebase

@dependabot
build(deps): Bump golang.org/x/sync from 0.15.0 to 0.16.0
1cbe18a 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.15.0 to 0.16.0.
- [Commits](golang/sync@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/sync-0.16.0 branch from 625f8a5 to 1cbe18a Compare July 19, 2025 20:39
ivanvc
ivanvc approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But, should we investigate why there's a performance drop in Windows' unit tests?

@ahrtr
Copy link
Member

ahrtr commented Jul 20, 2025

But, should we investigate why there's a performance drop in Windows' unit tests?

Probably it's just because of github's windows runner's problem.

If anyone has bandwidth, pls help us do some investigation:

  • raise PRs based on different history commits to figure out which commit(s) introduced the problem, similar to git-bisect

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, dependabot[bot], ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Elbehery
Copy link
Member

But, should we investigate why there's a performance drop in Windows' unit tests?

Probably it's just because of github's windows runner's problem.

If anyone has bandwidth, pls help us do some investigation:

* raise PRs based on different history commits to figure out which commit(s) introduced the problem, similar to [git-bisect](https://git-scm.com/docs/git-bisect)

On it 👍🏽

@ahrtr ahrtr merged commit 4485714 into main Jul 20, 2025
84 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/golang.org/x/sync-0.16.0 branch July 20, 2025 10:41
@Elbehery Elbehery mentioned this pull request Jul 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahrtr ahrtr ahrtr approved these changes

+1 more reviewer

@ivanvc ivanvc ivanvc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test size/XS

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k8s-ci-robot @ahrtr @ivanvc @Elbehery