Skip to content

Conversation

Elbehery
Copy link
Member

Signed-off-by: Mustafa Elbehery <[email protected]>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@Elbehery
Copy link
Member Author

@ahrtr we should wait for #723 to merge first, so that i adjust it accordingly in this PR 🙏🏽

@Elbehery
Copy link
Member Author

/hold

@ahrtr
Copy link
Member

ahrtr commented Apr 17, 2024

@ahrtr we should wait for #723 to merge first, so that i adjust it accordingly in this PR 🙏🏽

This PR is straightforward, I think it can be merged once the test green.
Afterwards please rebase #723.

@ahrtr ahrtr merged commit cc22218 into etcd-io:main Apr 17, 2024
@Elbehery Elbehery self-assigned this Apr 17, 2024
tjungblu pushed a commit to tjungblu/bbolt that referenced this pull request Apr 18, 2024
@Elbehery Elbehery deleted the use_cobra_exactArgs branch April 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Use cobra ExactArgs

2 participants