Don't require AppHost when publishing AOT #38644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Feb 9, 2024
|
I just saw @jkotas's comment in the other issue:
|
That's what the |
rolfbjarne
approved these changes
Feb 9, 2024
jkotas
approved these changes
Feb 9, 2024
4 tasks
|
/backport to release/8.0.4xx |
|
Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/10177576653 |
|
/backport to release/8.0.1xx |
|
Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/10177871330 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only delete it anyway.
Contributes to dotnet/runtime#89763
Contributes to dotnet/runtime#79575
_RuntimeIdentifierUsesAppHostis not a great name for this but I need exactly the same sematic. Renaming the existing property is not an option because there's external dependencies on this.Cc @dotnet/ilc-contrib @rolfbjarne @ViktorHofer