Add a concept of image family to container base image inference #33163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7caae57 to
0e9d2e2
Compare
0e9d2e2 to
7a3c317
Compare
|
Sorry to those pinged for review - I rebased from 7.0.4xx to main and so you all got notified. |
7a3c317 to
246e297
Compare
|
This is a great feature. Strong support for it. It's also just as needed for: <ContainerFamily>cbl-mariner2.0</ContainerFamily>and <ContainerFamily>cbl-mariner2.0-distroless</ContainerFamily> |
donJoseLuis
approved these changes
Aug 7, 2023
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageTag.cs
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageTag.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageTag.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageTag.cs
Show resolved
Hide resolved
246e297 to
7dfacad
Compare
this allows for easily selecting a group of related images (like chiseled or alpine) without having to 'eject' from inference overall
7dfacad to
15b82eb
Compare
ladipro
approved these changes
Aug 9, 2023
|
Thanks for the review, folks! |
|
Nice. Will this be in RC1? |
|
Should be - I believe cutoff is next Monday, so we're well under that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for easily selecting a group of related images (like chiseled or alpine) without having to 'eject' from inference overall. Right now we don't set this value anywhere, but further work might infer various properties and opt into chiseled ubuntu containers, for example. Or detect a musl RID and flip over to the alpine family of images.
Closes dotnet/sdk-container-builds#401
This is pretty crucial for making it easier for users to opt into Chiseled containers for example - with this, a user could add
to their project file and use the new, slim containers.