Spaces in the configuration name create invalid preprocessor defines #2715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace spaces if they exist in the configuration name.
|
@Gwindalmir thanks a lot for the PR. By any chance, could you add a test to cover this scenario? |
|
I'd love to... as soon as I figure out how to build the thing. I get the following error: I tried before and after installing the latest preview SDK, and I edited globals.json to match what I installed. EDIT: I found the Arcade project... |
|
No worries. We need to update the developer guide. Have you tried simply running build.cmd first? That's a requirement to get things going. |
Add same change to VB targets to transform spaces.
|
|
|
Done. For reference to others, my issue was I was using an older version of VS. |
livarcocc
approved these changes
Dec 6, 2018
nguerrera
approved these changes
Dec 11, 2018
|
@Gwindalmir any luck with the cla? |
|
Yup, I had to wait for my company to approve it (I submitted it here too early apparently). |
|
Thank you! |
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
….2 (#2715) - Microsoft.DotNet.Cli.Runtime - 3.0.100-rc1.19458.2
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
… merges/release/3.0.100-preview9-to-release/3.0.1xx * upstream/release/3.0.100-preview9: (21 commits) Update dependencies from https://github.com/Microsoft/msbuild build 20190906.2 (#2779) Update dependencies from https://github.com/dotnet/cli build 20190908.6 (#2728) Update dependencies from https://github.com/dotnet/sdk build 20190908.1 (#2726) Update dependencies from https://github.com/dotnet/cli build 20190908.2 (#2715) Update dependencies from https://github.com/aspnet/websdk build 20190908.1 (#2713) Update dependencies from https://github.com/dotnet/cli build 20190907.12 (#2710) Update dependencies from https://github.com/dotnet/cli build 20190907.11 (#2707) Update dependencies from https://github.com/aspnet/websdk build 20190907.5 (#2706) Update dependencies from https://github.com/dotnet/cli build 20190907.9 (#2705) Update dependencies from https://github.com/aspnet/websdk build 20190907.4 (#2704) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190907.3 (#2702) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190906.6 (#2675) Update dependencies from https://github.com/dotnet/cli build 20190906.12 (#2670) Update dependencies from https://github.com/dotnet/sdk build 20190906.2 (#2669) Update dependencies from https://github.com/Microsoft/msbuild build 20190905.2 (#2666) Update dependencies from https://github.com/dotnet/core-setup build 20190906.20 (#2668) Update dependencies from https://github.com/dotnet/cli build 20190906.11 (#2667) Update dependencies from https://github.com/dotnet/core-setup build 20190906.12 (#2659) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190905.12 (#2633) Update dependencies from https://github.com/Microsoft/msbuild build 20190830.3 (#2618) ... Conflicts: eng/Version.Details.xml eng/Versions.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a custom configuration, such as "Release Obfuscated", the implicit defines created contain spaces, but they don't throw any compiler errors. Though they are still unusable.
Replace spaces if they exist in the configuration name.
For example, as shown in Visual Studio IDE:
NETSTANDARD2_0;RELEASE OBFUSCATED;MYDEFINE