[25961] - dotnet watch first key press fix #26870
Conversation
|
@baronfel Hi! Sorry to bother you but the issue is assigned to you. Maybe you can review this PR? It's really small and I am just afraid that PR won't get in .NET7 release |
|
Yes of course! Thank you for the ping - this just slipped my mind. |
|
This looks good to me, but I'd appreciate @mkArtakMSFT or @captainsafia taking a look, as they own watch. |
1696530 to
462bbf0
Compare
|
@baronfel Hi! Can I do something to push this PR forward? |
There was a problem hiding this comment.
LGTM, although I don't own the watch area anymore. I think we'll need to update the CODEOWNERS file.
@Tunduk Is there a way to add tests for this scenario?
|
Thanks for your reply, @captainsafia ! I'll check if I can add a test for this. |
|
@tmat can you please review this? Thanks! |
| { | ||
| var key = Console.ReadKey(intercept: true); | ||
| for (var i = 0; i < _keyPressedListeners.Count; i++) | ||
| if (Console.KeyAvailable) |
There was a problem hiding this comment.
Yeah, you are right. I missed that.
I've tried to play around with the Process.StandartInput stream but it causes more problems.
Spinning CPU is bad, but I don't see another solution
There was a problem hiding this comment.
Of course, we can call something like Thread.Sleep(100) but this will not look good too
462bbf0 to
e17c1fa
Compare
|
Old PR review: This PR is more than a year old and does not appear to have active engagement. A reviewer has been notified offline to review and take action. If no action is taken, this PR will be closed in 14 days. Please comment if you want this PR left open for further investigation. |
Fixes #25961
Now dotnet-watch can't restart by Ctrl+R if watched process "take"
Console, but I don't think that it is a problem.