Use glob for signing resources #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @nguerrera |
nguerrera
approved these changes
Jun 22, 2017
nguerrera
reviewed
Jun 22, 2017
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="RoslynTools.Microsoft.SignTool" Version="0.2.0-beta" /> | ||
| <PackageReference Include="RoslynTools.Microsoft.SignTool" Version="0.3.3-beta" /> |
There was a problem hiding this comment.
That's the correct version. See https://dotnet.myget.org/feed/roslyn-tools/package/nuget/RoslynTools.Microsoft.SignTool/0.3.3-beta
nguerrera
suggested changes
Jun 22, 2017
|
Unfortunately, our CI doesn't validate signing like other repos yet. Since this is going to master (2.1), I can safely merge and check on the build once the version issue is fixed. |
nguerrera
reviewed
Jun 22, 2017
|
|
||
| <PropertyGroup> | ||
| <SignTool>$(NuGet_Packages)\roslyntools.microsoft.signtool\0.2.0-beta\tools\SignTool.exe</SignTool> | ||
| <SignTool>$(NuGet_Packages)\roslyntools.microsoft.signtool\3.3.0-beta\tools\SignTool.exe</SignTool> |
There was a problem hiding this comment.
I have all the right numbers, they're just in the wrong order 😄
nguerrera
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.