Skip to content

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Aug 6, 2020

Fixes #12614

@sfoslund sfoslund requested a review from a team as a code owner August 6, 2020 16:53
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just to confirm, net4.5.1 for example will still parse to a 3 part version number, right?

@sfoslund
Copy link
Member Author

sfoslund commented Aug 6, 2020

@dsplaisted yup, the tests that target net472/net451 cover 3 part target framework versions and this test case covers 3 part target platform versions.

@sfoslund sfoslund merged commit 3b0345f into dotnet:master Aug 6, 2020
@sfoslund sfoslund deleted the TFVersionLength branch August 6, 2020 21:26
sfoslund added a commit that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update version part logic for parsing TargetFramework and TargetPlatform versions

2 participants