Read default language for dotnet new from env var
#10666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For .NET Core Sdk 3.1.2xx is implemented in PR dotnet/cli#13237 It will be awesome to have it in the next LTS sdk 3.1.200 . |
fb4b109 to
4b607cc
Compare
4b607cc to
ebc7cb7
Compare
nguerrera
approved these changes
Feb 24, 2020
dsplaisted
approved these changes
Mar 9, 2020
| typeof(NupkgUpdater).GetTypeInfo().Assembly | ||
| }); | ||
|
|
||
| string preferredLangEnvVar = Environment.GetEnvironmentVariable("DOTNET_NEW_PREFERRED_LANG"); |
There was a problem hiding this comment.
I'd suggest renaming this to preferredLangEnvVarValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read
DOTNET_NEW_PREFERRED_LANGas default language fordotnet new.If not set, the default continue to be
C#Currently to create F# projects, we need to specify
-lang f#foreachdotnet newinvocation.It's really annoying, and atm
dotnet newdoesnt yet support set the preference property.This option can be removed later, when
dotnet newsupport set the default language (as normal config)With this pr
/cc @cartermp
ref #4224